Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change storage versions to v1beta1 #3169

Merged
merged 2 commits into from
May 22, 2020
Merged

change storage versions to v1beta1 #3169

merged 2 commits into from
May 22, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 19, 2020

Addresses #3095

Proposed Changes

  • Change storage version from v1alpha1 to v1beta1:
          - "parallels.flows.knative.dev"
          - "sequences.flows.knative.dev"
          - "eventtypes.eventing.knative.dev"
          - "triggers.eventing.knative.dev"
          - "channels.messaging.knative.dev"
          - "inmemorychannels.messaging.knative.dev"
          - "subscriptions.messaging.knative.dev"

Release Note

- 🧽 Update or clean up current behavior
Change storage versions from v1alpha1 to v1beta1:
          - "parallels.flows.knative.dev"
          - "sequences.flows.knative.dev"
          - "eventtypes.eventing.knative.dev"
          - "triggers.eventing.knative.dev"
          - "channels.messaging.knative.dev"
          - "inmemorychannels.messaging.knative.dev"
          - "subscriptions.messaging.knative.dev"

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2020
@vaikas vaikas mentioned this pull request May 21, 2020
Merged
grantr
grantr approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 12c1ec1 into knative:master May 22, 2020
@grantr grantr mentioned this pull request Jun 5, 2020
Merged
@aliok aliok mentioned this pull request Aug 25, 2020
Closed
@vaikas vaikas deleted the bump-storage-versions branch March 9, 2021 23:58
@vaikas vaikas mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr grantr approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaikas @knative-prow-robot @grantr @googlebot