-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile MT Broker using v1beta1 + fallout #3238
Conversation
Just a note about these tests, I removed locally the eventing/v1alpha1 directory to make sure I got all the references to them. Mainly a note to myself... |
The following is the coverage report on the affected files.
|
/assign @matzew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
also tested w/ e2e sample on k8s 1.18.3
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, n3wscott, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
Proposed Changes
Release Note
Docs