Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile MT Broker using v1beta1 + fallout #3238

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 30, 2020

Fixes #

Proposed Changes

  • Reconcile Broker for MT ChannelBasedBroker using v1beta1 API.

Release Note

- 🧽 Update or clean up current behavior
Reconcile Brokers using v1beta1 API

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 30, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 30, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2020
@vaikas
Copy link
Contributor Author

vaikas commented May 30, 2020

Just a note about these tests, I removed locally the eventing/v1alpha1 directory to make sure I got all the references to them. Mainly a note to myself...

@vaikas vaikas changed the title WIP: Reconcile MT Broker using v1beta1 + fallout Reconcile MT Broker using v1beta1 + fallout Jun 1, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2020
@vaikas vaikas mentioned this pull request Jun 1, 2020
@vaikas vaikas force-pushed the broker-to-v1beta1 branch from e96dfcb to b23e91f Compare June 2, 2020 02:35
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1beta1/broker_lifecycle.go 83.3% 95.5% 12.1
pkg/apis/eventing/v1beta1/test_helper.go 62.5% 68.6% 6.1
pkg/mtbroker/filter/filter_handler.go 78.3% 77.8% -0.5
pkg/reconciler/mtbroker/broker.go 73.2% 85.4% 12.3
pkg/reconciler/mtbroker/trigger.go 87.6% 87.5% -0.1
pkg/reconciler/source/duck/duck.go 71.0% 70.7% -0.3

@matzew
Copy link
Member

matzew commented Jun 2, 2020

/assign @matzew

Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

also tested w/ e2e sample on k8s 1.18.3

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matzew,n3wscott,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2bbfd5a into knative:master Jun 2, 2020
@vaikas vaikas deleted the broker-to-v1beta1 branch June 2, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants