Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an intermediate broker CRD for moving storage to v1beta1 #3282

Merged
merged 1 commit into from
Jun 5, 2020
Merged

add an intermediate broker CRD for moving storage to v1beta1 #3282

merged 1 commit into from
Jun 5, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jun 5, 2020

Fixes #

Proposed Changes

  • Add a Broker crd that has storage switched from v1alpha1 to v1beta1
  • We will use this while running the storage migration.

Release Note

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 5, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@knative-prow-robot knative-prow-robot merged commit 512447a into knative:master Jun 5, 2020
@vaikas vaikas deleted the updated-crd branch June 5, 2020 19:46
@vaikas vaikas mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaikas @knative-prow-robot @lionelvillard @googlebot