Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configmaplister, reduce trigger status churn #3609

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 16, 2020

Addresses #3591

As part of debugging the #3591 there were couple of things we could do better to reduce the churn on the API server, namely use configmap lister instead of hitting the API server. Also use the same logic for deciding whether to update Trigger Status just like we would do if we were using genreconciler.

Proposed Changes

  • use configmap lister
  • reduce trigger status churn

Release Note


Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 16, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/mtbroker/broker.go 85.4% 86.3% 0.9
pkg/reconciler/mtbroker/controller.go 84.6% 85.2% 0.6
pkg/reconciler/mtbroker/trigger.go 87.7% 87.9% 0.1

@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@knative-prow-robot knative-prow-robot merged commit 0617857 into knative:master Jul 16, 2020
@vaikas vaikas deleted the broker-chaos-improvements branch July 16, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants