add knobs for overriding qps / burst #3632
Conversation
knative-prow-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
cmd/mtchannel_broker/main.go
Outdated
| clientQPS := flag.Float64("clientQPS", 5.0, "Overrides rest.Config.DefaultQPS.") | ||
| clientBurst := flag.Int("clientBurst", 10.0, "Overrides rest.Config.Burst.") |
There was a problem hiding this comment.
| clientQPS := flag.Float64("clientQPS", 5.0, "Overrides rest.Config.DefaultQPS.") | |
| clientBurst := flag.Int("clientBurst", 10.0, "Overrides rest.Config.Burst.") | |
| // TODO(https://github.com/knative/eventing/issues/3591): switch back to sharedmain.Main | |
| clientQPS := flag.Float64("clientQPS", rest.DefaultQPS, "Overrides rest.Config.QPS.") | |
| clientBurst := flag.Int("clientBurst", rest.DefaultBurst, "Overrides rest.Config.Burst.") |
There was a problem hiding this comment.
I can do this, but I think it would still be useful to expose some of these knobs for tuning things?
There was a problem hiding this comment.
In the context here, we are exposing the knobs to raise the limits due to that linked issue, which is why I thought it most relevant here.
I agree the knobs are useful, but they probably belong in sharedmain, and ideally this would go back to being a fairly thin invocation of that.
|
Thanks, PTAL. I don't understand the unnecessary import by sockpuppet. |
|
The following jobs failed:
Automatically retrying due to test flakiness... |
Addresses #3591
Proposed Changes
Release Note
Docs