Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove event emit for normal trigger reconcile #3643

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 19, 2020

Addresses #knative/pkg#1520

While Matt and I were debugging things related to chaos, and in particular what happens to 'nop' controllers, we started looking at places were we are doing unnecessary api server calls. This is removing one of them.
Overarching issue tracking in /pkg
knative/pkg#1520

Proposed Changes

  • Do no emit trigger reconciled successfully event

Release Note

- 🧽 Update or clean up current behavior
When Trigger is reconciled, do not emit an event for it

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 19, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/mtbroker/broker.go 86.5% 86.5% -0.1

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2020
@knative-prow-robot knative-prow-robot merged commit 882d3a4 into knative:master Jul 19, 2020
@vaikas vaikas deleted the no-events-for-normal-trigger-reconciles branch July 21, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants