Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the event emission on every reconcile #3676

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 22, 2020

Addresses #knative/pkg#1520

Do not emit events for every reconcile. Add logging

Proposed Changes

  • Do not emit normal events for every reconcile
  • Add logging

Release Note

- 🗑️ Remove feature or internal logic

Do not emit k8s events for every successful reconcile of IMC

Docs

@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 22, 2020
@slinkydeveloper
Copy link
Contributor

/assign

@vaikas
Copy link
Contributor Author

vaikas commented Jul 22, 2020

/hold
need to remove couple of files.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@vaikas vaikas closed this Jul 22, 2020
@vaikas vaikas force-pushed the instrumentation branch from e19bd10 to 4f98fa7 Compare July 22, 2020 08:03
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2020
@vaikas vaikas reopened this Jul 22, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Jul 22, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/inmemorychannel/controller/inmemorychannel.go 75.5% 76.4% 0.8

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/conformance.TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1
test/conformance.TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1/full-event_encoding_binary_version_0.3

@pierDipi
Copy link
Member

Failed to create "InMemoryChannel" "full-event-binary-03-ch": conversion webhook for messaging.knative.dev/v1, Kind=InMemoryChannel failed: Post https://eventing-webhook.knative-eventing-l6byfp58r8.svc:443/resource-conversion?timeout=30s: EOF

/retest
/lgtm

@knative-prow-robot knative-prow-robot merged commit 2a51901 into knative:master Jul 22, 2020
@vaikas vaikas deleted the instrumentation branch July 22, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants