add post 017 job to remove pingsource finalizer #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/L
knative-prow-robot
added
the
area/test-and-release
pierDipi
reviewed
Aug 17, 2020
cmd/v0.17/pingsource-cleanup/main.go
Outdated
Comment on lines
41
to
42
| log.Printf("[ERROR] Failed to process env var: %s", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Suggested change
| log.Printf("[ERROR] Failed to process env var: %s", err) | |
| os.Exit(1) | |
| log.Fatalf("[ERROR] Failed to process env var: %s", err) |
cmd/v0.17/pingsource-cleanup/main.go
Outdated
| if !env.DryRun { | ||
| for _, ref := range cleanups { | ||
| fmt.Printf("# will remove finalizer for %s/%s\n", ref.Namespace, ref.Name) | ||
| ref.Finalizers = []string{} |
There was a problem hiding this comment.
If for any reason there are other finalizers, we drop them all, can we remove the specific finalizer we're looking for?
There was a problem hiding this comment.
I was just lazy :-) Do you think that's needed or can we leave it like this?
There was a problem hiding this comment.
done it and tested it.
lionelvillard
force-pushed
the
pingsource-v017-upgrade
branch
from
b38a432 to
92f3951
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3588
Proposed Changes
Release Note
Docs
@houshengbo