Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP DO NOT MERGE #3860

Closed
wants to merge 8 commits into from
Closed

WIP DO NOT MERGE #3860

wants to merge 8 commits into from

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 18, 2020

Experiments with #3789

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
To complete the pull request process, please assign matzew
You can assign the PR to them by writing /assign @matzew in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 18, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2020

This pull request introduces 4 alerts when merging 9aa80e0 into 9f3fb3f - view on LGTM.com

new alerts:

  • 4 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2020

This pull request introduces 4 alerts when merging 560ba2a into 9f3fb3f - view on LGTM.com

new alerts:

  • 4 for Identical operands

@knative-prow-robot
Copy link
Contributor

@aliok: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-unit-tests 560ba2a link /test pull-knative-eventing-unit-tests
pull-knative-eventing-upgrade-tests 560ba2a link /test pull-knative-eventing-upgrade-tests
pull-knative-eventing-integration-tests 560ba2a link /test pull-knative-eventing-integration-tests
pull-knative-eventing-conformance-tests 560ba2a link /test pull-knative-eventing-conformance-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 2020-08-18 12:40:10.837 +0000 UTC 1/3
pull-knative-eventing-integration-tests 0/3
pull-knative-eventing-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestChannelForwardHeadersPrependedWithKnative/Channel-messaging.knative.dev/v1
test/conformance.TestChannelForwardHeadersPrependedWithKnative/InMemoryChannel-messaging.knative.dev/v1beta1
test/conformance.TestChannelForwardHeadersPrependedWithKnative/Channel-messaging.knative.dev/v1beta1
test/conformance.TestChannelForwardHeadersPrependedWithKnative
test/conformance.TestBrokerV1Beta1DataPlaneIngress
test/conformance.TestBrokerV1Beta1ControlPlane/Channel-messaging.knative.dev/v1/Trigger_V1Beta1_with_Ready_broker_progresses_to_Ready
test/conformance.TestBrokerV1Beta1ControlPlane/Channel-messaging.knative.dev/v1
test/conformance.TestBrokerV1Beta1ControlPlane/InMemoryChannel-messaging.knative.dev/v1beta1/Trigger_V1Beta1_with_Ready_broker_progresses_to_Ready

and 60 more.

vaikas
vaikas reviewed Aug 18, 2020
View reviewed changes
test/conformance/helpers/channel_status_subscriber_test_helper.go
@@ -85,7 +86,7 @@ func channelHasRequiredSubscriberStatus(st *testing.T, client *testlib.Client, c
if channelable.Status.SubscribableStatus == nil || channelable.Status.SubscribableStatus.Subscribers == nil {
st.Fatalf("%q does not have status.subscribers", channel)
}
ss := findSubscriberStatus(channelable.Status.SubscribableStatus.Subscribers, subscription)
ss := findSubscriberStatusV1(channelable.Status.SubscribableStatus.Subscribers, subscription)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be using the v1alpha1 subscriber status instead of v1?

@aliok
Copy link
Member Author

aliok commented Aug 19, 2020

/close

@aliok aliok closed this Aug 19, 2020
@aliok aliok deleted the channel_reconciler branch April 28, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas left review comments

@Harwayne Harwayne Awaiting requested review from Harwayne

@steuhs steuhs Awaiting requested review from steuhs

Assignees
No one assigned
Labels
area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aliok @knative-prow-robot @knative-test-reporter-robot @vaikas @googlebot