-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add channel v1 duck type to spec #3870
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update the changelog section as well?
/lgtm
/hold
unhold if this can be done in another PR (please, open an issue to track this).
@Harwayne Did you cut the release yet, or will this make it? I wouldn't hold the release, but to address the release notes question. If this won't make the cut, it will go out in the next . release and will hence get added to release notes for it, so that should all be good? If you already cut the release, please unhold. |
.17 was already cut, this missed it, so I'm unholding and it will go in the . release. |
/hold cancel |
Add v1 channelable to the spec.
Proposed Changes
Release Note
Docs