Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add channel v1 duck type to spec #3870

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Aug 18, 2020

Add v1 channelable to the spec.

Proposed Changes

  • Add v1 channelable to the spec.

Release Note

- 🧽 Update or clean up current behavior
Update the spec to include v1 of the channelable.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the changelog section as well?

/lgtm
/hold

unhold if this can be done in another PR (please, open an issue to track this).

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Aug 18, 2020

@Harwayne Did you cut the release yet, or will this make it? I wouldn't hold the release, but to address the release notes question. If this won't make the cut, it will go out in the next . release and will hence get added to release notes for it, so that should all be good? If you already cut the release, please unhold.

@vaikas
Copy link
Contributor Author

vaikas commented Aug 18, 2020

.17 was already cut, this missed it, so I'm unholding and it will go in the . release.
/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Aug 18, 2020

/hold cancel

@knative-prow-robot knative-prow-robot merged commit 05d1644 into knative:master Aug 18, 2020
@vaikas vaikas deleted the v1spec branch September 22, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants