Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eager pingsource adapter creation #3987

Merged
merged 4 commits into from
Sep 4, 2020
Merged

Eager pingsource adapter creation #3987

merged 4 commits into from
Sep 4, 2020

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Sep 1, 2020 •
edited
Loading

Fixes #3035

Proposed Changes

  • the mtping adapter is now created at installation time, replicas = 0
  • the pingSource controller only updates environment variables
  • the pingSource controller sets replicas to 1 (if set to 0) when first PingSource is created

Release Note

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 1, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 1, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@lionelvillard
Copy link
Member Author

/hold

The controller needs to be updated as well.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 2020-09-01 14:32:25.228 +0000 UTC
2020-09-01 14:51:25.212 +0000 UTC
2020-09-01 15:09:25.393 +0000 UTC
2020-09-01 15:26:25.344 +0000 UTC		 3/3
pull-knative-eventing-integration-tests 2020-09-01 14:33:25.241 +0000 UTC
2020-09-01 14:51:55.37 +0000 UTC
2020-09-01 15:10:55.33 +0000 UTC
2020-09-01 15:28:55.31 +0000 UTC		 3/3
pull-knative-eventing-upgrade-tests 0/3

Job pull-knative-eventing-integration-tests expended all 3 retries without success.

@lionelvillard
Copy link
Member Author

/unhold

@aliok can you take a look at this one?

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@cr22rc
Copy link
Contributor

cr22rc commented Sep 1, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@lionelvillard
Copy link
Member Author

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@aliok
Copy link
Member

aliok commented Sep 2, 2020

/assign

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2020
mattmoor
mattmoor reviewed Sep 3, 2020
View reviewed changes
config/500-pingsource-mt-adapter.yaml
@@ -0,0 +1 @@
core/deployments/pingsource-mt-adapter.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing newline:

Suggested change
core/deployments/pingsource-mt-adapter.yaml
core/deployments/pingsource-mt-adapter.yaml

@lionelvillard
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pingsource/controller.go 90.5% 88.9% -1.6
pkg/reconciler/pingsource/pingsource.go 69.4% 63.2% -6.2

@aliok
Copy link
Member

aliok commented Sep 4, 2020

/test pull-knative-eventing-unit-tests

Doesn't seem related to your changes:

?   	knative.dev/eventing/pkg/reconciler/parallel/resources	[no test files]
WARN invalid TestEvent: FAIL	knative.dev/eventing/pkg/reconciler/sequence [build failed]
bad output from test2json: FAIL	knative.dev/eventing/pkg/reconciler/sequence [build failed]

aliok
aliok approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c40a2a2 into knative:master Sep 4, 2020
@aliok
Copy link
Member

aliok commented Sep 4, 2020

@lionelvillard
I tried to simply cherry pick the changes to 0.17 and it fails badly.

What do you think about backporting this?

@lionelvillard
Copy link
Member Author

@aliok how badly?

@aliok
Copy link
Member

aliok commented Sep 4, 2020

LOL, huge conflicts because of deleted shapes, renamed adapter, simplified logic, etc. :)

@lionelvillard
Copy link
Member Author

@aliok We are fine not backporting it.

@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas left review comments

@mattmoor mattmoor mattmoor left review comments

@aliok aliok aliok approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@aliok aliok

@cr22rc cr22rc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pingsource-jobrunner has no ownerref
9 participants
@lionelvillard @knative-test-reporter-robot @cr22rc @aliok @knative-metrics-robot @knative-prow-robot @mattmoor @vaikas @googlebot