Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GetCondition and patch merge to ClusterProvisionerStatus #436

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Adding GetCondition and patch merge to ClusterProvisionerStatus #436

merged 2 commits into from
Sep 18, 2018

Conversation

n3wscott
Copy link
Contributor

Relates to #434

Proposed Changes

  • Adding GetCondition on ClusterProvisionerStatus
  • Adding patchStrategy:"merge" to ClusterProvisionerStatus.Conditions

Release Note

None

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2018
@n3wscott
Copy link
Contributor Author

/assign @grantr

Addressed feedback from #434

@n3wscott n3wscott changed the title Addressing feedback, adding GetCondition method and merge strat. Adding GetCondition patch merge to ClusterProvisionerStatus Sep 18, 2018
@n3wscott n3wscott changed the title Adding GetCondition patch merge to ClusterProvisionerStatus Adding GetCondition and patch merge to ClusterProvisionerStatus Sep 18, 2018
grantr
grantr approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2018
@knative-prow-robot knative-prow-robot merged commit 67761f0 into knative:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr grantr approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n3wscott @knative-prow-robot @grantr