Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline to GetGenericObject log line in testing #4636

Merged

Conversation

lberk
Copy link
Member

@lberk lberk commented Dec 8, 2020

Related: #4634

Proposed Changes

  • Add a newline at the end of the GetGenericObject() error message that may be causing a variety of our flakey tests

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 8, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Dec 8, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #4636 (e5a4407) into master (1d3519c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4636   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         290      290           
  Lines        8176     8176           
=======================================
  Hits         6648     6648           
  Misses       1128     1128           
  Partials      400      400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3519c...e5a4407. Read the comment docs.

@pierDipi
Copy link
Member

pierDipi commented Dec 8, 2020

/test pull-knative-eventing-integration-tests
/test pull-knative-eventing-conformance-tests

@lionelvillard
Copy link
Member

/lgtm
/approve

Thanks @lberk !!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lberk
Copy link
Member Author

lberk commented Dec 8, 2020

/test pull-knative-eventing-integration-tests

@zhongduo
Copy link
Contributor

zhongduo commented Dec 8, 2020

/lgtm

@knative-prow-robot knative-prow-robot merged commit d3bff1f into knative:master Dec 8, 2020
@lberk lberk linked an issue Dec 8, 2020 that may be closed by this pull request
@lionelvillard
Copy link
Member

/cherrypick release-0.19

@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #4646

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
5 participants