-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerSource stored version v1 and migration tool #4657
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is based on #4655. |
Codecov Report
@@ Coverage Diff @@
## master #4657 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 291 291
Lines 8216 8216
=======================================
Hits 6661 6661
Misses 1154 1154
Partials 401 401 Continue to review full report at Codecov.
|
Flaky #4637 |
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@@ -38,3 +38,4 @@ spec: | |||
image: ko://knative.dev/eventing/vendor/knative.dev/pkg/apiextensions/storageversion/cmd/migrate | |||
args: | |||
- "apiserversources.sources.knative.dev" | |||
- "containersources.sources.knative.dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About your attention in the PR, with this post install job, when using the operator this version migration will work, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
/cc @houshengbo
/lgtm |
/lgtm |
EOF errors and gotestsum bug,
/retest |
Fixes #4325
Proposed Changes
Release Note