Use wait_for_pods instead of kubectl wait for pods. Fix #4725

[vaikas]

Fixes #4725

Proposed Changes

• Use ./hack scripts instead of simple kubectl wait.

Release Note

- :bug: Fix bug where sometimes the pods were not deemed up during setup. #4725

Docs

[codecov]

Codecov Report

Merging #4741 (55f2153) into master (d74dc25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4741   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files         291      291           
  Lines        8235     8235           
=======================================
  Hits         6679     6679           
  Misses       1156     1156           
  Partials      400      400           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74dc25...ef0027c. Read the comment docs.

[pierDipi]

/lgtm
/hold

Unhold once this is ready.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vaikas]

@pierDipi thanks, you cool with removing the hold? Now similar to the prow e2e tests where we have not seen failures of this sort.

Run set -e
  set -e
  source ./vendor/knative.dev/hack/infra-library.sh
  wait_until_pods_running ${SYSTEM_NAMESPACE}
  shell: /bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GOPATH: /home/runner/work/eventing/eventing
    GO111MODULE: off
    KO_DOCKER_REPO: kind.local
    SYSTEM_NAMESPACE: knative-eventing
    CLUSTER_SUFFIX: c485165237.local
    ARTIFACTS: /home/runner/work/eventing/eventing/artifacts
    GOROOT: /opt/hostedtoolcache/go/1.15.6/x64
Waiting until all pods in namespace knative-eventing are up
All pods are up:
eventing-controller-5b4599b949-6c8b5    1/1   Running       0     26s
eventing-webhook-779f7c49cd-smmds       1/1   Running       0     26s
imc-controller-79b9fb796d-cmclm         1/1   Running       0     85s
imc-dispatcher-59566f9d66-zqhcn         1/1   Running       0     85s
mt-broker-controller-6dbdb9c9b4-xwb8m   1/1   Running       0     26s
mt-broker-filter-84fb998cd9-mpzlz       1/1   Running       0     88s
mt-broker-ingress-6c45959977-skthc      1/1   Running       0     87s
sugar-controller-67cc9fddff-sb2sd       1/1   Running       0     26s
zipkin-7fcb9b4ff8-kk5wn                 1/1   Running       0     73s

[vaikas]

Downstream keda failure is something that @slinkydeveloper is looking at.

[pierDipi]

/unhold