-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing fixed for apiserversource #4842
Conversation
Hi @Shashankft9. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @Harwayne |
Codecov Report
@@ Coverage Diff @@
## master #4842 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 292 292
Lines 8322 8322
=======================================
Hits 6768 6768
Misses 1145 1145
Partials 409 409
Continue to review full report at Codecov.
|
/ok-to-test |
/lgtm |
hmm what more do we need to send this through? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, Shashankft9 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Shashankft9 can you add a release note? |
Fixes #
#1889
Proposed Changes
more: Remove incorrect host names from tracing setup. #1990
Release Note