fix #4994 use trigger's namespace only when subscriber's namespace is nil

[zhaojizhuang]

Fixes #4994 #4628

Proposed Changes

• 🐛 Fix bug subscriber's NameSpace do not work in Trigger  #4994 Support MT broker match triggers defined in external namespaces #4628, Allow Trigger users to set another namespace's Subscriber, And when Subscriber's namespace not been set, it will be set to Trigger's namespace

Release Note

Allow Trigger users to set another namespace's Subscriber, And when Subscriber's namespace not been set, it will be set to  Trigger's namespace 

Docs

[zhaojizhuang]

/assign @pierDipi

[zhaojizhuang]

/assign @slinkydeveloper

[codecov]

Codecov Report

Merging #4995 (31399c5) into master (d6d48a7) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4995      +/-   ##
==========================================
- Coverage   82.63%   82.60%   -0.03%     
==========================================
  Files         294      294              
  Lines        8401     8401              
==========================================
- Hits         6942     6940       -2     
- Misses       1062     1063       +1     
- Partials      397      398       +1     

Impacted Files	Coverage Δ
pkg/reconciler/mtbroker/trigger/trigger.go	80.00% <0.00%> (-1.54%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d48a7...a38e9e9. Read the comment docs.

[zhaojizhuang]

/test pull-knative-eventing-integration-tests

[slinkydeveloper]

/lgtm
/approve

/hold for @vaikas review

[zhaojizhuang]

cc @vaikas #4994 (comment)

[zhaojizhuang]

/ok-to-test

[zhaojizhuang]

cc @vaikas

[zhaojizhuang]

/test pull-knative-eventing-unit-tests

[zhaojizhuang]

/retest

[zhaojizhuang]

@pierDipi @mattmoor The UT robot didn't pull the right code,and fun failed

[pierDipi]

hmm, that's weird
/retest

[pierDipi]

If you rebase you will see the error locally as well.

[pierDipi]

/lgtm

[zhaojizhuang]

If you rebase you will see the error locally as well.

@pierDipi but it run successfully locally

[zhaojizhuang]

/retest

[pierDipi]

I did it yesterday, did you update your master branch?

[zhaojizhuang]

I did it yesterday, did you update your master branch?

@pierDipi yeah, I rebase it to run UT,but it failed again. can anyone fix the Robot?

[pierDipi]

zhaojizhuang#1

[zhaojizhuang]

/retest

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/mtbroker/trigger/trigger.go	87.0%	86.1%	-0.9

[pierDipi]

This fixes #4628 too.

Can you add a release note? The example is in https://raw.githubusercontent.com/knative/eventing/master/.github/pull-request-template.md

/lgtm

[zhaojizhuang]

This fixes #4628 too.

Can you add a release note? The example is in https://raw.githubusercontent.com/knative/eventing/master/.github/pull-request-template.md

/lgtm

yeah, happy to add a release note

[vaikas]

Thanks!
/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi,slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vaikas]

/unhold

[zhaojizhuang]

/test pull-knative-eventing-unit-tests