Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more coverage #4999

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 1, 2021

Fixes #4968

Proposed Changes

  • Get them coverage numbers up for trigger / controller

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 1, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/mtbroker/trigger/controller.go 81.5% 88.9% 7.4
pkg/reconciler/mtbroker/trigger/trigger.go 80.0% 87.0% 7.0

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #4999 (954128e) into master (fba3dbf) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4999      +/-   ##
==========================================
+ Coverage   81.63%   81.80%   +0.16%     
==========================================
  Files         294      294              
  Lines        8392     8392              
==========================================
+ Hits         6851     6865      +14     
+ Misses       1135     1125      -10     
+ Partials      406      402       -4     
Impacted Files Coverage Δ
pkg/reconciler/mtbroker/trigger/trigger.go 81.53% <100.00%> (+8.46%) ⬆️
pkg/reconciler/mtbroker/trigger/controller.go 92.10% <0.00%> (+7.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba3dbf...7f407b5. Read the comment docs.

Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!!!!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@knative-prow-robot knative-prow-robot merged commit f220668 into knative:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.0] Code Coverage needs to be increased >=80% for pkg/reconcile/mtbroker
4 participants