Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1alpha1 channelable #5005

Merged

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 2, 2021

Fixes #

Proposed Changes

  • 🧹 Remove the v1alpha1 duck types from eventing as they are no longer used anymore, nor have they been used for a long time.
  • Preparation for removal of v1beta1 work here and there as well. Not the goal, but while at it did it at some spots.

Release Note

 :broom: v1alpha1 Channel duck types are no longer supported.

Docs

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Mar 2, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #5005 (829467f) into master (9089b8e) will increase coverage by 0.44%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5005      +/-   ##
==========================================
+ Coverage   82.39%   82.84%   +0.44%     
==========================================
  Files         294      288       -6     
  Lines        8391     8009     -382     
==========================================
- Hits         6914     6635     -279     
+ Misses       1073      994      -79     
+ Partials      404      380      -24     
Impacted Files Coverage Δ
pkg/reconciler/subscription/subscription.go 82.20% <75.00%> (+11.99%) ⬆️
pkg/reconciler/channel/channel.go 72.13% <100.00%> (+0.52%) ⬆️
pkg/reconciler/channel/controller.go 100.00% <100.00%> (ø)
pkg/reconciler/subscription/controller.go 100.00% <100.00%> (ø)
...inmemorychannel/controller/resources/dispatcher.go 100.00% <0.00%> (ø)
pkg/mtbroker/filter/filter_handler.go 80.40% <0.00%> (+1.35%) ⬆️
pkg/reconciler/source/config_watcher.go 79.06% <0.00%> (+18.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9089b8e...829467f. Read the comment docs.

@vaikas vaikas changed the title [WIP] Remove v1alpha1 channelable Remove v1alpha1 channelable Mar 3, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2021
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2021
@vaikas
Copy link
Contributor Author

vaikas commented Mar 4, 2021

/retest

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/channel/channel.go 77.8% 76.1% -1.7
pkg/reconciler/subscription/subscription.go 76.6% 86.9% 10.3

@n3wscott
Copy link
Contributor

n3wscott commented Mar 4, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Contributor Author

vaikas commented Mar 4, 2021

/retest

flaky comformance tests with rekt

@knative-prow-robot knative-prow-robot merged commit dbf1859 into knative:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants