-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move eventing-contrib/cmd/* here #5295
Move eventing-contrib/cmd/* here #5295
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5295 +/- ##
==========================================
+ Coverage 83.34% 83.64% +0.30%
==========================================
Files 243 243
Lines 6879 6896 +17
==========================================
+ Hits 5733 5768 +35
+ Misses 797 785 -12
+ Partials 349 343 -6
Continue to review full report at Codecov.
|
Lint fails with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested the event-display with the png source:
k logs -f -l serving.knative.dev/service=event-display -c user-container
specversion: 1.0
type: dev.knative.sources.ping
source: /apis/v1/namespaces/default/pingsources/ping-source
id: 93439c6d-0f05-45b3-85c2-78ca77cd64a6
time: 2021-04-22T06:57:00.20280561Z
datacontenttype: application/json
Data,
{
"message": "Hello world!"
}
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The eventing-contrib/cmd tools were left around after the various other pieces moved to knative-sandbox/* repos. There have been no releases for those since Dec 2020. As agreed, we decided to move them into the knative/eventing repo so that we'll get proper updates / releases, etc.
Couple of notes:
Proposed Changes
Pre-review Checklist
These are simple tools used for our docs examples that are simply moved here. I'll create the docs PR once I verify the release goes (I'll test with nightly) out correctly.
Release Note
Docs
knative/docs#3489