Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1 instead of v1beta1 and v1alpha1 #5316

Merged
merged 5 commits into from
Apr 27, 2021
Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented Apr 27, 2021

Fixes #

Proposed Changes

  • 🧹 Replace some v1alphas and v1betas with v1s
  • Some of them could actually stay as is but let's change them to reduce confusion

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 27, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 27, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/source/duck/duck.go 83.3% 9.8% -73.5

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #5316 (51b358c) into main (178be6b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5316   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files         243      243           
  Lines        6896     6896           
=======================================
  Hits         5771     5771           
  Misses        783      783           
  Partials      342      342           
Impacted Files Coverage Δ
pkg/adapter/apiserver/adapter.go 62.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178be6b...51b358c. Read the comment docs.

@matzew
Copy link
Member

matzew commented Apr 27, 2021 via email

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@matzew
Copy link
Member

matzew commented Apr 27, 2021

/assign @lionelvillard

for final approval

@lionelvillard
Copy link
Member

Cool!
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@knative-prow-robot knative-prow-robot merged commit fc44024 into knative:main Apr 27, 2021
@aliok aliok deleted the more-v1 branch April 28, 2021 06:41
@aliok aliok changed the title More v1 Use v1 instead of v1beta1 and v1alpha1 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants