-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove sources v1alpha2 APIs #5318
remove sources v1alpha2 APIs #5318
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5318 +/- ##
==========================================
- Coverage 83.56% 83.04% -0.53%
==========================================
Files 233 211 -22
Lines 6674 6292 -382
==========================================
- Hits 5577 5225 -352
+ Misses 762 737 -25
+ Partials 335 330 -5
Continue to review full report at Codecov.
|
@maximilien @rhuss @navidshaikh AFAIK, |
We are also dropping v1beta1 APIs |
…ive#5318 Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…ive#5318 Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
/unhold @lionelvillard thanks for the heads up ! Let's unhold and merge so that we increase the pressure a bit on the client side ;-P Background why the client always chooses the oldest available API: |
I'm working on the downstream tests failure for rabbitmq. I understand somebody else is working on the kafka failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoineco, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ive#5318 Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs
/hold needs to coordinate with Client WG. @maximilien @rhuss @navidshaikh