Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sources v1alpha2 APIs #5318

Merged

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Apr 27, 2021

Fixes #

Proposed Changes

  • Remove all core source v1alpha2 APIs

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

:wastebasket  Remove APIServerSource, ContainerSource, PingSource and SinkBinding v1alpha2 APIs

Docs

/hold needs to coordinate with Client WG. @maximilien @rhuss @navidshaikh

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Apr 27, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #5318 (b9789c5) into main (474fb5b) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5318      +/-   ##
==========================================
- Coverage   83.56%   83.04%   -0.53%     
==========================================
  Files         233      211      -22     
  Lines        6674     6292     -382     
==========================================
- Hits         5577     5225     -352     
+ Misses        762      737      -25     
+ Partials      335      330       -5     
Impacted Files Coverage Δ
pkg/broker/filter/filter_handler.go 85.81% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474fb5b...b9789c5. Read the comment docs.

@lionelvillard
Copy link
Member Author

@maximilien @rhuss @navidshaikh AFAIK, kn still relies on v1alpha2 source APIs. We are dropping them in 0.23 so this change will break knative/client

@lionelvillard
Copy link
Member Author

We are also dropping v1beta1 APIs

@lionelvillard lionelvillard mentioned this pull request Apr 27, 2021
5 tasks
matzew added a commit to matzew/eventing that referenced this pull request Apr 28, 2021
…ive#5318

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing that referenced this pull request Apr 28, 2021
…ive#5318

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@rhuss
Copy link
Contributor

rhuss commented Apr 28, 2021

/unhold

@lionelvillard thanks for the heads up ! Let's unhold and merge so that we increase the pressure a bit on the client side ;-P

Background why the client always chooses the oldest available API: kn favours backwards compatibility (i.e a newer client can work with an older cluster) over forward compatibility (i.e. an older client can work with a newer cluster).

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@vaikas
Copy link
Contributor

vaikas commented Apr 28, 2021

I'm working on the downstream tests failure for rabbitmq. I understand somebody else is working on the kafka failures?

Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@knative-prow-robot knative-prow-robot merged commit c2d6649 into knative:main Apr 28, 2021
matzew added a commit to matzew/eventing that referenced this pull request Apr 29, 2021
…ive#5318

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Apr 29, 2021
…ive#5318 (#1232)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants