Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pingsource v1 API #5324

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add pingsource v1 API #5324

merged 1 commit into from
Apr 29, 2021

Conversation

lionelvillard
Copy link
Member

Part of #4928

Proposed Changes

  • Promote PingSource to v1

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

 :gift: Promote PingSource to v1

Docs

/hold Depends on #5319

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 28, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #5324 (f3de6dc) into main (0bfa8de) will decrease coverage by 0.07%.
The diff coverage is 78.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5324      +/-   ##
==========================================
- Coverage   82.36%   82.28%   -0.08%     
==========================================
  Files         189      194       +5     
  Lines        5902     6002     +100     
==========================================
+ Hits         4861     4939      +78     
- Misses        720      739      +19     
- Partials      321      324       +3
Impacted Files Coverage Δ
pkg/apis/sources/v1/ping_lifecycle.go 60.00% <60.00%> (ø)
pkg/apis/sources/v1beta2/ping_conversion.go 60.00% <60.00%> (-40.00%) ⬇️
pkg/apis/sources/v1/ping_conversion.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1/ping_defaults.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1/ping_types.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1/ping_validation.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1/register.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bfa8de...f3de6dc. Read the comment docs.

@lionelvillard
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1/ping_conversion.go Do not exist 100.0%
pkg/apis/sources/v1/ping_defaults.go Do not exist 100.0%
pkg/apis/sources/v1/ping_lifecycle.go Do not exist 68.0%
pkg/apis/sources/v1/ping_types.go Do not exist 100.0%
pkg/apis/sources/v1/ping_validation.go Do not exist 100.0%
pkg/apis/sources/v1beta2/ping_conversion.go 100.0% 66.7% -33.3

n3wscott
n3wscott approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/reconciler/testing/v1/pingsource.go
for _, opt := range o {
opt(c)
}
c.SetDefaults(context.Background()) // TODO: We should add defaults and validation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it time to do this now? before it is v1? or as it becomes v1?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@knative-prow-robot knative-prow-robot merged commit 6363a8f into knative:main Apr 29, 2021
@dsimansk dsimansk mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott approved these changes

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lionelvillard @knative-metrics-robot @knative-prow-robot @n3wscott