Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duck/test: add initial tests for missing functions #5367

Merged
merged 1 commit into from
May 7, 2021

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented May 7, 2021

Fixes #4961

Proposed Changes

  • 🎁 Add initial tests for pkg/duck

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

NONE

Docs

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2021
@knative-prow-robot
Copy link
Contributor

Welcome @cpanato! It looks like this is your first PR to knative/eventing 🎉

@knative-prow-robot
Copy link
Contributor

Hi @cpanato. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2021
@cpanato
Copy link
Contributor Author

cpanato commented May 7, 2021

/assign @n3wscott

I'm very new to this project and did not fully understand it yet, the tests is reusing other parts of the existing tests

@matzew
Copy link
Member

matzew commented May 7, 2021

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/duck/channel.go 76.7% 81.4% 4.7
pkg/duck/listable.go 54.7% 88.7% 34.0

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #5367 (73b9680) into main (88d8a3e) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5367      +/-   ##
==========================================
+ Coverage   82.35%   82.65%   +0.29%     
==========================================
  Files         194      194              
  Lines        6002     6002              
==========================================
+ Hits         4943     4961      +18     
+ Misses        737      717      -20     
- Partials      322      324       +2     
Impacted Files Coverage Δ
pkg/duck/channel.go 63.63% <0.00%> (+9.09%) ⬆️
pkg/duck/listable.go 83.09% <0.00%> (+19.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d8a3e...73b9680. Read the comment docs.

Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a fine test to me!! thanks so much @cpanato and welcome to Knative :D

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@knative-prow-robot knative-prow-robot merged commit f1f4615 into knative:main May 7, 2021
@cpanato cpanato deleted the GH-4961 branch May 7, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.0] Code Coverage needs to be increased >=80% for pkg/duck
5 participants