-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duck/test: add initial tests for missing functions #5367
Conversation
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Welcome @cpanato! It looks like this is your first PR to knative/eventing 🎉 |
Hi @cpanato. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @n3wscott I'm very new to this project and did not fully understand it yet, the tests is reusing other parts of the existing tests |
/ok-to-test |
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## main #5367 +/- ##
==========================================
+ Coverage 82.35% 82.65% +0.29%
==========================================
Files 194 194
Lines 6002 6002
==========================================
+ Hits 4943 4961 +18
+ Misses 737 717 -20
- Partials 322 324 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a fine test to me!! thanks so much @cpanato and welcome to Knative :D
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4961
Proposed Changes
Pre-review Checklist
Release Note
Docs