Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription.Spec.Channel now uses KReference #5412

Merged
merged 4 commits into from
May 19, 2021

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented May 19, 2021

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #5411

Proposed Changes

  • 🧹 Subscription.Spec.Channel now uses KReference.
  • 🐛 Now the spec.channel CRD schema is less permissive and matches the supported usage of KReference fields.

Pre-review Checklist

  • At least 80% unit test coverage

Release Note

- :broom: Subscription.Spec.Channel now uses KReference and the spec.channel CRD schema is less permissive and matches the supported usage of KReference fields. Subscription's users creating their resources with YAMLs are not affected.

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #5412 (8a98937) into main (0653ac4) will decrease coverage by 0.05%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
- Coverage   82.68%   82.62%   -0.06%     
==========================================
  Files         194      194              
  Lines        6006     5987      -19     
==========================================
- Hits         4966     4947      -19     
  Misses        717      717              
  Partials      323      323              
Impacted Files Coverage Δ
pkg/apis/messaging/v1/subscription_types.go 66.66% <ø> (ø)
pkg/reconciler/subscription/subscription.go 82.12% <66.66%> (ø)
...essaging/v1/subscribable_channelable_validation.go 100.00% <100.00%> (ø)
pkg/apis/messaging/v1/subscription_validation.go 85.00% <100.00%> (ø)
pkg/reconciler/broker/resources/subscription.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0653ac4...8a98937. Read the comment docs.

@slinkydeveloper
Copy link
Contributor Author

/test pull-knative-eventing-conformance-tests

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@knative-prow-robot knative-prow-robot merged commit 453e4c0 into knative:main May 19, 2021
@slinkydeveloper slinkydeveloper deleted the issues/5411 branch May 19, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription.Spec.Channel should use KReference instead of corev1.ObjectReference
3 participants