Make eventing channel metrics generic enough to be used by other impl #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/S
|
Conformance test timed out. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
skonto
added a commit
to skonto/eventing
that referenced
this pull request
Jun 16, 2021
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Jun 17, 2021
…ka (#1318) * make eventing metrics generic (knative#5478) * Expose dispatch result to be used by other implementations (knative#5481) * expose dispatch result to be used by other implementations * expose fields * add getters etc * less verbose * Use transformers efficiently for extracting info for metrics in Kafka Channel (knative#5505) * use transformers for extracting event type for metrics * fix * fix * pass transformers to executeRequest (knative#5512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For more check here why these changes are needed.
Pre-review Checklist
This does not add new func its basically a refactoring.
/cc @slinkydeveloper @matzew