Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky test #5508

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Remove flaky test #5508

merged 1 commit into from
Jun 15, 2021

Conversation

benmoss
Copy link
Member

@benmoss benmoss commented Jun 14, 2021

It was not really testing anything but the library. I tried to make it less flaky but couldn't, I don't totally understand something about the way the http listener behaves.

Fixes #5474

It was not really testing anything but the library
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 14, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/v2/cloudevents.go 89.7% 87.2% -2.6

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #5508 (a4cf357) into main (393e411) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5508   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         197      198    +1     
  Lines        6098     6098           
=======================================
  Hits         5044     5044           
  Misses        729      729           
  Partials      325      325           
Impacted Files Coverage Δ
pkg/adapter/v2/cloudevents.go 81.91% <0.00%> (-2.13%) ⬇️
pkg/kncloudevents/retries.go 84.61% <0.00%> (ø)
pkg/kncloudevents/message_sender.go 86.95% <0.00%> (+4.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393e411...a4cf357. Read the comment docs.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@knative-prow-robot knative-prow-robot merged commit 02403a5 into knative:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flaky] pkg/adapter/v2.TestNewCloudEventsClient_receiver/binary_event
4 participants