-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test DeliverySpec.Timeout for Trigger #5565
Test DeliverySpec.Timeout for Trigger #5565
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #5565 +/- ##
=======================================
Coverage 82.62% 82.62%
=======================================
Files 198 198
Lines 6154 6154
=======================================
Hits 5085 5085
Misses 742 742
Partials 327 327 Continue to review full report at Codecov.
|
This fails because of #5566 |
@slinkydeveloper: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi wanna see to get this aligned or adjusted ? |
We added these tests in #5687, I guess we can close this PR (?) |
ah! cool - did not see that. Great! /close |
@matzew: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Part of #5148
Proposed Changes
DeliverySpec.Timeout
forTrigger