-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new ListableTracker ctor taking a tracker.Interface #5651
Create a new ListableTracker ctor taking a tracker.Interface #5651
Conversation
PSA: I'm opening this to survey what breaks, I don't plan to check this in as-is. This is in a similar vein to: knative/pkg#2220 EDIT: I've updated this to be in a form we can check in (deprecate the old method) |
Codecov Report
@@ Coverage Diff @@
## main #5651 +/- ##
==========================================
- Coverage 82.73% 82.71% -0.02%
==========================================
Files 200 200
Lines 6266 6267 +1
==========================================
Hits 5184 5184
- Misses 750 751 +1
Partials 332 332
Continue to review full report at Codecov.
|
I noticed in a few places downstream that reconcilers were creating multiple trackers, which seems superfluous. As part of examining the way we use the tracker, I'm experimenting with changing this to just take a tracker. /kind cleanup
8a7c5bf
to
5f54e95
Compare
The following is the coverage report on the affected files.
|
/assign @n3wscott |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I noticed in a few places downstream that reconcilers were creating multiple trackers, which seems superfluous. As part of examining the way we use the tracker, I'm experimenting with changing this to just take a tracker.
/kind cleanup
Pre-review Checklist
Release Note
Docs