Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post jobs] Like serving use generatedName #5664

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[post jobs] Like serving use generatedName #5664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions config/post-install/storage-version-migrator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,18 @@
apiVersion: batch/v1
kind: Job
metadata:
# Adding a prefix to avoid naming conflict with previous version's post-install jobs,
# we cannot use `generateName` here as it's not supported by `kubectl apply -f`
#
# If `ttlSecondsAfterFinished` feature gate becomes generally available in the future,
# we can rely on that and keep using the same Job name.
name: v0.23-storage-version-migration
generateName: storage-version-migration-eventing-
namespace: knative-eventing
labels:
app: "storage-version-migration"
app: "storage-version-migration-eventing"
eventing.knative.dev/release: devel
spec:
ttlSecondsAfterFinished: 600
backoffLimit: 10
template:
metadata:
labels:
app: "storage-version-migration"
app: "storage-version-migration-eventing"
eventing.knative.dev/release: devel
annotations:
sidecar.istio.io/inject: "false"
Expand Down