Adding all resources for NOOP migrator #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## main #5694 +/- ##
==========================================
+ Coverage 82.68% 82.81% +0.12%
==========================================
Files 200 200
Lines 6261 6324 +63
==========================================
+ Hits 5177 5237 +60
Misses 750 750
- Partials 334 337 +3
Continue to review full report at Codecov.
|
config/post-install/clusterrole.yaml
Outdated
| - "eventing.knative.dev" | ||
| resources: | ||
| - "brokers" | ||
| - "eventtype" |
5 tasks
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
noop_migrator_for_all
branch
from
f39c67f to
c538c0d
Compare
matzew
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
/unhold the other PR is merged |
knative-prow-robot
removed
the
do-not-merge/hold
|
we are now ready for the NOOP post-job thingy .... Mind taking a look? |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Proposed Changes
/hold
wait untl #5664 is merged
Pre-review Checklist
Release Note
Docs