Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed ginkgo from the project and ran update-codegen #5878

Merged
merged 1 commit into from
Nov 8, 2021
Merged

removed ginkgo from the project and ran update-codegen #5878

merged 1 commit into from
Nov 8, 2021

Conversation

gabo1208
Copy link
Member

@gabo1208 gabo1208 commented Nov 5, 2021

Fixes #5876

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 5, 2021
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021 •
edited
Loading

Codecov Report

Merging #5878 (77a7975) into main (4cc5ecf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5878   +/-   ##
=======================================
  Coverage   81.96%   81.96%           
=======================================
  Files         220      220           
  Lines        7458     7458           
=======================================
  Hits         6113     6113           
  Misses        918      918           
  Partials      427      427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc5ecf...77a7975. Read the comment docs.

@gabo1208
Copy link
Member Author

gabo1208 commented Nov 5, 2021

/retest

@odacremolbap
Copy link
Contributor

@gabo1208 thanks so much for this:
image

I'd swear I saw some BDD at eventing but either it was removed or I'm confusing with some other repo.
Either case ✔️

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2021
@odacremolbap
Copy link
Contributor

/assign @dprotaso

failing tests are being worked on at the kafka repos:

@odacremolbap odacremolbap mentioned this pull request Nov 6, 2021
Closed
@odacremolbap
Copy link
Contributor

micro-nit: can you update the title? just in case someone gets confused by what needs to be done when updating deps, there is no need to call update-codegen, and go mod tidy is included as part of the go_update_deps function, no need to explicitly call it:

https://github.com/knative/eventing/blob/main/DEVELOPMENT.md#iterating

@gabo1208 gabo1208 changed the title removed ginkgo from the project and ran update-codegen and mod tidy removed ginkgo from the project and ran update-codegen Nov 6, 2021
@dprotaso
Copy link
Member

dprotaso commented Nov 6, 2021

/unassign @dprotaso
/assign @lionelvillard

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, odacremolbap, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@knative-prow-robot knative-prow-robot merged commit ee96d0b into knative:main Nov 8, 2021
@gabo1208 gabo1208 mentioned this pull request Nov 8, 2021
Closed
odacremolbap pushed a commit to odacremolbap/eventing that referenced this pull request Nov 9, 2021
@gabo1208 @odacremolbap
removed ginkgo from the project and ran update-codegen and mod tidy (k…
20b42b1 
…native#5878)
knative-prow-robot pushed a commit that referenced this pull request Dec 16, 2021
@odacremolbap @gabo1208
kebabfy broker channel spec and pingsource opts (#5875)
6f1ed33 
* kebabfy broker channel spec and pingsource opts

* removed ginkgo from the project and ran update-codegen and mod tidy (#5878)

* add tests using legacy channel template configuration element

Co-authored-by: Gabriel Freites <gfreites@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@odacremolbap odacremolbap odacremolbap approved these changes

Assignees

@lionelvillard lionelvillard

@odacremolbap odacremolbap

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Ginkgo from the project tests
6 participants
@gabo1208 @odacremolbap @dprotaso @knative-prow-robot @pierDipi @lionelvillard