Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k8s trace attribute to ApiServerSource #6458

Merged

Conversation

liuchangyan
Copy link
Contributor

@liuchangyan liuchangyan commented Jul 25, 2022

Partial fix for #5888

Proposed Changes

This PR is to add some k8s trace attributes to ApiServerSource.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

 Traces generated by ApiServerSource includes some k8s attributes  (`k8s.namespace`, `k8s.name`).

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 25, 2022

Hi @liuchangyan. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #6458 (38b6dbd) into main (c8435ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6458   +/-   ##
=======================================
  Coverage   82.15%   82.16%           
=======================================
  Files         235      235           
  Lines       11694    11699    +5     
=======================================
+ Hits         9607     9612    +5     
  Misses       1620     1620           
  Partials      467      467           
Impacted Files Coverage Δ
pkg/adapter/apiserver/events/events.go 94.11% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@liuchangyan liuchangyan force-pushed the apiserver-source-tracing-add branch from 1667d73 to 85819f9 Compare July 25, 2022 04:15
@xxinran
Copy link

xxinran commented Jul 26, 2022

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2022
@liuchangyan liuchangyan force-pushed the apiserver-source-tracing-add branch 2 times, most recently from 891e4fa to 61db515 Compare July 26, 2022 08:17
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2022
@liuchangyan liuchangyan force-pushed the apiserver-source-tracing-add branch from 61db515 to 38b6dbd Compare July 26, 2022 08:23
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2022
@liuchangyan liuchangyan changed the title apiserversource tracing add add k8s attributes to traces of apiserversource Jul 26, 2022
@liuchangyan liuchangyan changed the title add k8s attributes to traces of apiserversource add k8s trace attribute to Apiserversource Jul 26, 2022
@liuchangyan liuchangyan changed the title add k8s trace attribute to Apiserversource add k8s trace attribute to ApiServerSource Jul 26, 2022
@lionelvillard
Copy link
Member

thanks @liuchangyan for your PR. It looks great! Can you just update the release notes to be more specific that this PR adds tracing attributes to the APIServerSource?

We should also add unit tests and e2e tests. That can be done in a separate PR.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, liuchangyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@liuchangyan
Copy link
Contributor Author

liuchangyan commented Aug 4, 2022

thanks @liuchangyan for your PR. It looks great! Can you just update the release notes to be more specific that this PR adds tracing attributes to the APIServerSource?

We should also add unit tests and e2e tests. That can be done in a separate PR.

/lgtm /approve

ok

@knative-prow knative-prow bot merged commit 32dea96 into knative:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants