-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add k8s trace attribute to ApiServerSource #6458
add k8s trace attribute to ApiServerSource #6458
Conversation
Hi @liuchangyan. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #6458 +/- ##
=======================================
Coverage 82.15% 82.16%
=======================================
Files 235 235
Lines 11694 11699 +5
=======================================
+ Hits 9607 9612 +5
Misses 1620 1620
Partials 467 467
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1667d73
to
85819f9
Compare
/ok-to-test |
891e4fa
to
61db515
Compare
61db515
to
38b6dbd
Compare
thanks @liuchangyan for your PR. It looks great! Can you just update the release notes to be more specific that this PR adds tracing attributes to the APIServerSource? We should also add unit tests and e2e tests. That can be done in a separate PR. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, liuchangyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok |
Partial fix for #5888
Proposed Changes
This PR is to add some k8s trace attributes to ApiServerSource.
Pre-review Checklist
Release Note