Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore trailing slashes for Broker requests #6471

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Ignore trailing slashes for Broker requests #6471

merged 1 commit into from
Aug 4, 2022

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 4, 2022 •
edited
Loading

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Fixes #6467

Proposed Changes

  • Ignore trailing slashes for Broker requests

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

MT Broker ignores a trailing slash in the HTTP path.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2022
@pierDipi
Copy link
Member Author

pierDipi commented Aug 4, 2022

/cc @matzew @lionelvillard

@knative-prow knative-prow bot requested review from lionelvillard and matzew August 4, 2022 08:37
@codecov
Copy link

codecov bot commented Aug 4, 2022 •
edited
Loading

Codecov Report

Merging #6471 (9643971) into main (15dd7ca) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6471   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         235      235           
  Lines       11694    11694           
=======================================
  Hits         9607     9607           
  Misses       1620     1620           
  Partials      467      467
Impacted Files Coverage Δ
pkg/broker/ingress/ingress_handler.go 77.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pierDipi pierDipi force-pushed the KNATIVE-6467_Ignore-trailing-slash branch from 433102d to 42548db Compare August 4, 2022 09:12
@pierDipi
Ignore trailing slashes for Broker addresses
9643971 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the KNATIVE-6467_Ignore-trailing-slash branch from 42548db to 9643971 Compare August 4, 2022 09:12
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2022
@pierDipi pierDipi requested review from matzew and aliok August 4, 2022 09:14
aliok
aliok approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

All good unless it breaks a test case :)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7e30288 into knative:main Aug 4, 2022
pierDipi added a commit to pierDipi/eventing that referenced this pull request Aug 4, 2022
@pierDipi
Ignore trailing slashes for Broker addresses (knative#6471)
808acf7 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-ci bot pushed a commit to openshift/knative-eventing that referenced this pull request Aug 5, 2022
@pierDipi
Ignore trailing slashes for Broker addresses (knative#6471) (#1832)
d32f7da 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-eventing that referenced this pull request Aug 5, 2022
@pierDipi
Ignore trailing slashes for Broker addresses (knative#6471)
bb1e921 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-eventing that referenced this pull request Aug 5, 2022
@pierDipi
Ignore trailing slashes for Broker addresses (knative#6471)
ee7871c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-ci bot pushed a commit to openshift/knative-eventing that referenced this pull request Aug 5, 2022
@openshift-cherrypick-robot @pierDipi
Ignore trailing slashes for Broker addresses (knative#6471) (#1836)
6286a1e 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-ci bot pushed a commit to openshift/knative-eventing that referenced this pull request Aug 5, 2022
@openshift-cherrypick-robot @pierDipi
Ignore trailing slashes for Broker addresses (knative#6471) (#1835)
e237f43 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broker ingress does not accept request on endpoint with trailing slash
3 participants
@pierDipi @matzew @aliok