Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative port sink binding v1 deployment test to rekt #6479

Conversation

liuchangyan
Copy link
Contributor

@liuchangyan liuchangyan commented Aug 11, 2022

Proposed Changes

  • Port SinkbindingV1Deployment test to rekt

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Port SinkbindingV1Deployment test to rekt, and fix some complie errors

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #6479 (b8bb9be) into main (c8435ed) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6479   +/-   ##
=======================================
  Coverage   82.15%   82.16%           
=======================================
  Files         235      235           
  Lines       11694    11700    +6     
=======================================
+ Hits         9607     9613    +6     
  Misses       1620     1620           
  Partials      467      467           
Impacted Files Coverage Δ
pkg/apis/eventing/v1/trigger_validation.go 86.66% <0.00%> (-0.78%) ⬇️
pkg/broker/ingress/ingress_handler.go 77.33% <0.00%> (ø)
pkg/apis/messaging/v1/subscription_types.go 66.66% <0.00%> (ø)
pkg/adapter/apiserver/events/events.go 94.11% <0.00%> (+0.30%) ⬆️
pkg/kncloudevents/message_receiver.go 93.50% <0.00%> (+1.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@liuchangyan liuchangyan force-pushed the KNATIVE_Port-SinkBindingV1Deployment-test-to-rekt branch from 374adc9 to 3eb6a24 Compare August 11, 2022 10:11
@lionelvillard
Copy link
Member

@liuchangyan this looks great! thanks!

Can you fix the linter error and the copyright year?

@liuchangyan
Copy link
Contributor Author

liuchangyan commented Aug 11, 2022

@liuchangyan this looks great! thanks!

Can you fix the linter error and the copyright year?

Thanks for your review, but the Code Style EOF newline error seems my github token is not permitted to modify this file: https://github.com/knative/eventing/blob/main/test/rekt/resources/deployment/deployment.yaml, is there any other way I can fix it?

@lionelvillard
Copy link
Member

@liuchangyan have you tried adding a new line?

@liuchangyan liuchangyan force-pushed the KNATIVE_Port-SinkBindingV1Deployment-test-to-rekt branch from b2514c4 to b8bb9be Compare August 11, 2022 17:24
@liuchangyan
Copy link
Contributor Author

@liuchangyan have you tried adding a new line?

That works, thks:)

@lionelvillard
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, liuchangyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@knative-prow knative-prow bot merged commit aceb557 into knative:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants