-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knative port sink binding v1 deployment test to rekt #6479
Knative port sink binding v1 deployment test to rekt #6479
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6479 +/- ##
=======================================
Coverage 82.15% 82.16%
=======================================
Files 235 235
Lines 11694 11700 +6
=======================================
+ Hits 9607 9613 +6
Misses 1620 1620
Partials 467 467
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
374adc9
to
3eb6a24
Compare
@liuchangyan this looks great! thanks! Can you fix the linter error and the copyright year? |
Thanks for your review, but the Code Style EOF newline error seems my github token is not permitted to modify this file: https://github.com/knative/eventing/blob/main/test/rekt/resources/deployment/deployment.yaml, is there any other way I can fix it? |
@liuchangyan have you tried adding a new line? |
b2514c4
to
b8bb9be
Compare
That works, thks:) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, liuchangyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
Pre-review Checklist
Release Note