Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS certificate rotation tests #7103

Merged
merged 20 commits into from
Aug 3, 2023
Merged

TLS certificate rotation tests #7103

merged 20 commits into from
Aug 3, 2023

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jul 24, 2023 •
edited
Loading

Fixes #7039

Proposed Changes

  • Test broker ingress TLS key pair rotation
  • Test IMC dispatcher TLS key pair rotation

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jul 24, 2023
@knative-prow knative-prow bot requested review from lionelvillard and mgencur July 24, 2023 16:36
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (91e156c) 77.92% compared to head (478d813) 77.94%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7103      +/-   ##
==========================================
+ Coverage   77.92%   77.94%   +0.02%     
==========================================
  Files         248      248              
  Lines       13257    13257              
==========================================
+ Hits        10330    10333       +3     
+ Misses       2400     2398       -2     
+ Partials      527      526       -1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi pierDipi force-pushed the rotate-broker-ingress-TLS-test branch from cacdd98 to 309f233 Compare July 24, 2023 16:53
@pierDipi pierDipi mentioned this pull request Jul 24, 2023
Closed
5 tasks
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2023
@pierDipi pierDipi force-pushed the rotate-broker-ingress-TLS-test branch from a3fe491 to d067ab1 Compare July 26, 2023 11:20
@pierDipi pierDipi mentioned this pull request Jul 28, 2023
Closed
3 tasks
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2023
pierDipi added 10 commits August 1, 2023 08:33
@pierDipi
Broker ingress TLS certificate rotation test
53252c5 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Install Eventing TLS YAML
d6a2c6a 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Run hack/update-deps.sh
c7521a0 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Update Subscription when immutable spec.channel is unchanged
9a5b8bc 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Watch config-features in IMC controller
54ea266 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
IMC dispatcher TLS certificate rotation test
6763fe3 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Install cert-manager first
9c9d165 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Upgrade rekt
95d9db8 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Match 202 status code
bfc3345 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Upgrade rekt
1957a69 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the rotate-broker-ingress-TLS-test branch from 86ba344 to 1957a69 Compare August 1, 2023 06:39
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2023
@pierDipi pierDipi changed the title [WIP] Broker ingress TLS certificate rotation test [WIP] TLS certificate rotation tests Aug 1, 2023
pierDipi added 2 commits August 1, 2023 08:49
@pierDipi
Rotate filter certificate as well even though we cannot verify its ro…
71fb636 
…tation E2E

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Remove status code matching
5f37c64 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Merge main
c055e2e 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
pierDipi added 2 commits August 2, 2023 16:47
@pierDipi
Change prerequisite text to match condition
b62276c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Remove changes to trigger reconciler
7221ddc 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
pierDipi added 2 commits August 2, 2023 17:34
@pierDipi
Align deps to main
81a3dd7 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Merge branch 'main' into rotate-broker-ingress-TLS-test
68c2ace
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
pierDipi added 2 commits August 2, 2023 17:38
@pierDipi
Fix formatting and linting
913ea53 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Install cert-manager during upgrade tests
16a6de8 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi changed the title [WIP] TLS certificate rotation tests TLS certificate rotation tests Aug 3, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2023
@pierDipi pierDipi requested review from Leo6Leo and creydr August 3, 2023 07:11
@pierDipi
Copy link
Member Author

pierDipi commented Aug 3, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

pierDipi commented Aug 3, 2023

@creydr @Leo6Leo please take a look at this PR

@pierDipi
Rename test to better describe what they do
478d813 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@creydr
Copy link
Member

creydr commented Aug 3, 2023

/test upgrade-tests

@knative-prow knative-prow bot merged commit 8a90e40 into knative:main Aug 3, 2023
@knative-prow-robot
Copy link
Contributor

@pierDipi: #7103 failed to apply on top of branch "release-1.11":

Applying: Broker ingress TLS certificate rotation test
Applying: Install Eventing TLS YAML
Applying: Run hack/update-deps.sh
Applying: Update Subscription when immutable spec.channel is unchanged
Applying: Watch config-features in IMC controller
Using index info to reconstruct a base tree...
M	pkg/reconciler/inmemorychannel/controller/controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/inmemorychannel/controller/controller.go
CONFLICT (content): Merge conflict in pkg/reconciler/inmemorychannel/controller/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0005 Watch config-features in IMC controller
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr creydr mentioned this pull request Aug 3, 2023
Merged
@pierDipi pierDipi deleted the rotate-broker-ingress-TLS-test branch October 11, 2023 14:06
Leo6Leo pushed a commit to Leo6Leo/eventing that referenced this pull request Oct 11, 2023
@pierDipi @Leo6Leo
TLS certificate rotation tests (knative#7103)
80c55ac 
Fixes knative#7039

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes

<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

- Test broker ingress TLS key pair rotation
- Test IMC dispatcher TLS key pair rotation

### Pre-review Checklist

<!-- If these boxes are not checked, you will be asked to complete these
requirements or explain why they do not apply to your PR. -->

- [ ] **At least 80% unit test coverage**
- [ ] **E2E tests** for any new behavior
- [ ] **Docs PR** for any user-facing impact
- [ ] **Spec PR** for any new API feature
- [ ] **Conformance test** for any change to the spec

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note

```


**Docs**

<!--
📖 If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Leo6Leo pushed a commit to Leo6Leo/eventing that referenced this pull request Oct 11, 2023
@pierDipi @Leo6Leo
TLS certificate rotation tests (knative#7103)
b17e531 
Fixes knative#7039

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes

<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

- Test broker ingress TLS key pair rotation
- Test IMC dispatcher TLS key pair rotation

### Pre-review Checklist

<!-- If these boxes are not checked, you will be asked to complete these
requirements or explain why they do not apply to your PR. -->

- [ ] **At least 80% unit test coverage**
- [ ] **E2E tests** for any new behavior
- [ ] **Docs PR** for any user-facing impact
- [ ] **Spec PR** for any new API feature
- [ ] **Conformance test** for any change to the spec

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note

```


**Docs**

<!--
📖 If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot pushed a commit that referenced this pull request Oct 11, 2023
@Leo6Leo @pierDipi
[release-1.11] TLS certificate rotation tests (#7103) (#7346)
46cc775 
TLS certificate rotation tests (#7103)

Fixes #7039

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes

<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

- Test broker ingress TLS key pair rotation
- Test IMC dispatcher TLS key pair rotation

### Pre-review Checklist

<!-- If these boxes are not checked, you will be asked to complete these
requirements or explain why they do not apply to your PR. -->

- [ ] **At least 80% unit test coverage**
- [ ] **E2E tests** for any new behavior
- [ ] **Docs PR** for any user-facing impact
- [ ] **Spec PR** for any new API feature
- [ ] **Conformance test** for any change to the spec

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note

```


**Docs**

<!--
📖 If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-ci bot pushed a commit to openshift-knative/eventing that referenced this pull request Oct 11, 2023
@Leo6Leo @pierDipi
TLS certificate rotation tests (knative#7103) (#374)
41e699b 
Fixes knative#7039

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes

<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

- Test broker ingress TLS key pair rotation
- Test IMC dispatcher TLS key pair rotation

### Pre-review Checklist

<!-- If these boxes are not checked, you will be asked to complete these
requirements or explain why they do not apply to your PR. -->

- [ ] **At least 80% unit test coverage**
- [ ] **E2E tests** for any new behavior
- [ ] **Docs PR** for any user-facing impact
- [ ] **Spec PR** for any new API feature
- [ ] **Conformance test** for any change to the spec

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note

```


**Docs**

<!--
📖 If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr left review comments

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@mgencur mgencur Awaiting requested review from mgencur

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eventing TLS: test mt-broker-ingress, mt-broker-filter, and imc-dispatcher TLS key pairs rotation
4 participants
@pierDipi @knative-prow-robot @creydr @Leo6Leo