Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers to work with service accounts for OIDC #7278

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 22, 2023

Fixes #7277

Proposed Changes

  • 🎁 Helpers to work with service accounts for OIDC

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Hints for reviewers:

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@401068c). Click here to learn what that means.
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7278   +/-   ##
=======================================
  Coverage        ?   77.58%           
=======================================
  Files           ?      250           
  Lines           ?    13431           
  Branches        ?        0           
=======================================
  Hits            ?    10421           
  Misses          ?     2485           
  Partials        ?      525           
Files Coverage Δ
pkg/auth/serviceaccount.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/auth/serviceaccount.go Outdated Show resolved Hide resolved
@creydr creydr requested a review from matzew September 25, 2023 11:00
@creydr
Copy link
Member Author

creydr commented Sep 25, 2023

@matzew could you recheck?

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f10a44d into knative:main Sep 26, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helper to create service accounts used for OIDC authentication
2 participants