Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AuthStatus to OIDC identity providing resources #7287

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

karthikmurali60
Copy link
Contributor

Fixes #7173

Proposed Changes

  • 🎁 Add new feature
  • add the AuthStatus struct
  • add the AuthStatus API in resources, which need to provide their OIDC identity (and update their CRDs):
    • Trigger
    • Subscription
    • Sequence
    • Parallel
    • Sources of eventing core (ApiServerSource, PingSource, ContainerSource, SinkBinding)
    • SubscriberStatus for Channels

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 23, 2023

Hi @karthikmurali60. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b898cf4) 77.62% compared to head (dc4030e) 77.64%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7287      +/-   ##
==========================================
+ Coverage   77.62%   77.64%   +0.01%     
==========================================
  Files         249      250       +1     
  Lines       13412    13436      +24     
==========================================
+ Hits        10411    10432      +21     
- Misses       2478     2480       +2     
- Partials      523      524       +1     
Files Coverage Δ
pkg/apis/duck/v1/subscribable_types.go 100.00% <ø> (ø)
pkg/apis/eventing/v1/trigger_types.go 100.00% <ø> (ø)
pkg/apis/flows/v1/parallel_types.go 100.00% <ø> (ø)
pkg/apis/flows/v1/sequence_types.go 100.00% <ø> (ø)
pkg/apis/messaging/v1/subscription_types.go 66.66% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member

creydr commented Sep 25, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2023
@karthikmurali60
Copy link
Contributor Author

/retest

@karthikmurali60
Copy link
Contributor Author

@creydr I have made the changes and run the hack/update-codegen.sh script. Despite this, some of the tests are failing where the error message suggests to run the script. Why could this be happening ? Am I missing something ?

@creydr
Copy link
Member

creydr commented Sep 26, 2023

@creydr I have made the changes and run the hack/update-codegen.sh script. Despite this, some of the tests are failing where the error message suggests to run the script. Why could this be happening ? Am I missing something ?

Hey @karthikmurali60,
when I run the ./hack/update-codegen.sh on your branch, it tells me, that it renamed some license file. So it seems you need to run it again.
Besides of that, to solve the merge conflicts, you need to rebase your branch (probably, because the changes from 13ffbe5 landed in the main branch via #7297)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2023
Signed-off-by: karthikmurali60 <karthik.murali60@gmail.com>
@creydr
Copy link
Member

creydr commented Sep 26, 2023

@karthikmurali60: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_eventing_main 4bc344f link true /test build-tests
Your PR dashboard.

/home/prow/go/src/knative.dev/eventing is out of date. Please run hack/update-codegen.sh

Seems you need to run hack/update-codegen.sh again

Signed-off-by: karthikmurali60 <karthik.murali60@gmail.com>
@karthikmurali60 karthikmurali60 changed the title Add AuthStatus and add to OIDC identity providing resources Add AuthStatus to OIDC identity providing resources Sep 27, 2023
@creydr
Copy link
Member

creydr commented Sep 27, 2023

/retest

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution and patience @karthikmurali60 ! 🎉

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, karthikmurali60

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@knative-prow knative-prow bot merged commit 44aa15e into knative:main Sep 27, 2023
28 of 32 checks passed
@karthikmurali60 karthikmurali60 deleted the add-auth-status branch September 27, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AuthStatus and add to OIDC identity providing resources
3 participants