-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AuthStatus to OIDC identity providing resources #7287
Conversation
Hi @karthikmurali60. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7287 +/- ##
==========================================
+ Coverage 77.62% 77.64% +0.01%
==========================================
Files 249 250 +1
Lines 13412 13436 +24
==========================================
+ Hits 10411 10432 +21
- Misses 2478 2480 +2
- Partials 523 524 +1
☔ View full report in Codecov by Sentry. |
f9b2c6b
to
ae4d616
Compare
/ok-to-test |
/retest |
@creydr I have made the changes and run the |
Hey @karthikmurali60, |
13ffbe5
to
347409f
Compare
config/channels/in-memory-channel/resources/in-memory-channel.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: karthikmurali60 <karthik.murali60@gmail.com>
347409f
to
4bc344f
Compare
Seems you need to run hack/update-codegen.sh again |
Signed-off-by: karthikmurali60 <karthik.murali60@gmail.com>
4bc344f
to
dc4030e
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution and patience @karthikmurali60 ! 🎉
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, karthikmurali60 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7173
Proposed Changes
Pre-review Checklist
Release Note
Docs