Add audience field for Subscriber and Reply to SubscriberSpec and SubscriptionStatusPhysicalSubscription
#7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
|
/assign @pierDipi |
…bscriptionStatusPhysicalSubscription
creydr
force-pushed
the
add-audience-field-to-subscriber-and-subscribable
branch
from
7cde5a3 to
544b13f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7296 +/- ##
==========================================
+ Coverage 77.59% 77.62% +0.02%
==========================================
Files 249 249
Lines 13404 13412 +8
==========================================
+ Hits 10401 10411 +10
+ Misses 2479 2478 -1
+ Partials 524 523 -1
☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7293
Proposed Changes
As we need to provide the Audiences of the Subscriber and Reply in the Subscription, this PR adds the Audience of Subscriber and Reply to SubscriberSpec and SubscriptionStatusPhysicalSubscription.