-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger create and expose OIDC service account #7299
Conversation
14538c6
to
e4fefda
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7299 +/- ##
==========================================
- Coverage 77.66% 77.54% -0.13%
==========================================
Files 250 250
Lines 13436 13491 +55
==========================================
+ Hits 10435 10461 +26
- Misses 2478 2506 +28
- Partials 523 524 +1
☔ View full report in Codecov by Sentry. |
9c74693
to
27f7e0b
Compare
@pierDipi since we have a new status condition, we need to update the other broker implementations too (at least the tests). We will probably need to do that for the other resources (e.g. Subscriptions) too :/ |
/retest |
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7222
Proposed Changes
.status.auth.serviceAccountName
Release Note