-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Ready timeout for TestChannelConformance to 4 minutes #7433
Increase Ready timeout for TestChannelConformance to 4 minutes #7433
Conversation
The default 2-minute timeout might not be enough in some scenarios where deploying takes longer (like with Istio).
/cherry-pick release-1.11 |
@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.12 |
@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7433 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 253 253
Lines 13916 13916
=======================================
Hits 10680 10680
Misses 2702 2702
Partials 534 534 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @creydr
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mgencur: new pull request created: #7442 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mgencur: new pull request created: #7443 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The default 2-minute timeout might not be enough in some scenarios where deploying takes longer (like with Istio).
Proposed Changes
Pre-review Checklist
Release Note
Docs