Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable storage of EventType v1b2 #7594

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

dsimansk
Copy link
Contributor

Based on Slack thread: https://cloud-native.slack.com/archives/C04LMU33V1S/p1705560044668329.

Proposed Changes

  • Enable storage of EventType v1b2

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Enable storage of EventType `v1beta2` instead of `v1beta1`

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@knative-prow knative-prow bot requested review from aslom and pierDipi January 18, 2024 10:24
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (7cba45b) 74.52% compared to head (d30fa58) 74.44%.
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/broker/filter/filter_handler.go 13.33% 11 Missing and 2 partials ⚠️
pkg/channel/fanout/fanout_event_handler.go 71.79% 7 Missing and 4 partials ⚠️
pkg/broker/ingress/ingress_handler.go 40.00% 1 Missing and 2 partials ⚠️
pkg/channel/event_receiver.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7594      +/-   ##
==========================================
- Coverage   74.52%   74.44%   -0.08%     
==========================================
  Files         262      262              
  Lines       14970    15041      +71     
==========================================
+ Hits        11157    11198      +41     
- Misses       3223     3243      +20     
- Partials      590      600      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor Author

/test upgrade-tests

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@dsimansk dsimansk force-pushed the pr/eventtypes-v1b2-storage branch from 5163fa4 to aea0e90 Compare January 18, 2024 15:54
@dsimansk
Copy link
Contributor Author

/test reconciler-tests

@dsimansk
Copy link
Contributor Author

dsimansk commented Jan 19, 2024

@pierDipi @matzew I would say it's good for the review now with update tests passing. PTAL

Hence the test setup changes are required for proper update sequence with version migration.

@dsimansk dsimansk force-pushed the pr/eventtypes-v1b2-storage branch from f908a43 to d30fa58 Compare January 22, 2024 17:10
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
Copy link

knative-prow bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit fd95228 into knative:main Jan 23, 2024
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants