wathola receiver, annotate span by step number #7667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maschmid
commented
Feb 12, 2024
maschmid
commented
- 🧹 annotate received span by step number, to help debugging upgrade tests
knative-prow
bot
added
area/test-and-release
maschmid
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maschmid, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7667 +/- ##
=======================================
Coverage 73.98% 73.98%
=======================================
Files 262 262
Lines 15178 15178
=======================================
Hits 11229 11229
Misses 3343 3343
Partials 606 606 ☔ View full report in Codecov by Sentry. |
mgencur
reviewed
Feb 12, 2024
maschmid
force-pushed
the
maschmid-prober-receiver-annotate-received-span
branch
from
3f43a52 to
e130c07
Compare
|
/lgtm |
This was referenced Feb 12, 2024
Closed
pierDipi
pushed a commit
to pierDipi/eventing
that referenced
this pull request
Mar 28, 2024
wathole receiver, annotate span by step number
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Apr 2, 2024
…nt received (knative#7668) (#580) * Wait for events with poll interval after finished event received (knative#7668) * Wait for events with poll interval after finished event received * Use PollUntilContextCancel * Change default timeout to 30 seconds * Call cancel * Simplify * wathola receiver, annotate span by step number (knative#7667) wathole receiver, annotate span by step number --------- Co-authored-by: Martin Gencur <mgencur@redhat.com> Co-authored-by: Marek Schmidt <maschmid@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.