Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EventType Autocreate Async #7709

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

Cali0707
Copy link
Member

Fixes #7098

Proposed Changes

  • Make the eventtype autocreate function async
EventType Autocreate is now a non blocking operation

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot requested review from aslom and matzew February 20, 2024 18:51
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2024
Copy link

knative-prow bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@Cali0707
Copy link
Member Author

/cc @pierDipi @matzew @dsimansk @Leo6Leo

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 73.99%. Comparing base (79a5488) to head (431a860).
Report is 17 commits behind head on main.

Files Patch % Lines
pkg/eventtype/eventtypes.go 69.38% 12 Missing and 3 partials ⚠️
pkg/broker/ingress/ingress_handler.go 0.00% 1 Missing ⚠️
pkg/channel/fanout/fanout_event_handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7709      +/-   ##
==========================================
+ Coverage   73.98%   73.99%   +0.01%     
==========================================
  Files         262      262              
  Lines       15178    15178              
==========================================
+ Hits        11229    11231       +2     
+ Misses       3343     3341       -2     
  Partials      606      606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Member

matzew commented Feb 21, 2024

/retest

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

/retest

1 similar comment
@Cali0707
Copy link
Member Author

/retest

Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 5, 2024

/retest

@knative-prow knative-prow bot merged commit 6e7728e into knative:main Mar 5, 2024
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a EventTypeAutoCreateAsync method
3 participants