-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker, Trigger, and Namespace Controllers #788
Broker, Trigger, and Namespace Controllers #788
Conversation
Remove restClient as it wasn't actually used.
Only reconcile the Namespace if the specific resource we care about changes
Accept v0.1 and v0.2 cloud events. Adding UTs.
Created knative/eventing-contrib#252 in eventing-sources to add broker read only permissions. It should be merged right after this one, otherwise sources won't be able to point to brokers. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I got this to work after not reading the documentation and not creating the correct service account and role binding. There is a bug in this code, the broker becomes ready when it does not have pods for the filter. The ingress pods come up and the filter pods never did. I updated my chatbot demo to broker/trigger, here are the changes: |
I agree, #915. |
Mark the Broker's Ingress and Filter status condidionts failed when they have failed.
Do not DeepCopy() in Reconcile(), as controller-runtime already did it for us
The following is the coverage report on pkg/.
|
/lgtm 💪 |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Proposed Changes
Broker
andTrigger
controllers.Namespace
watcher.With thanks to:
Release Note