-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid fatal errors for unknown features flags that can be added in a future release #8051
Avoid fatal errors for unknown features flags that can be added in a future release #8051
Conversation
…future release Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
/cherry-pick release-1.14 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8051 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.01%
==========================================
Files 364 364
Lines 17042 17043 +1
==========================================
Hits 11538 11538
- Misses 4783 4784 +1
Partials 721 721 ☔ View full report in Codecov by Sentry. |
@pierDipi: new pull request created: #8052 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Once backported fixes Upgrade test failures like https://prow.knative.dev/view/gcs/knative-prow/logs/continuous_eventing_main_periodic/1806130105928388608
Proposed Changes
Pre-review Checklist
Release Note
Docs