Disable controller default health probes in the IMC dispatcher #8125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IMC dispatcher is using the same server receiving events
for k8s readiness and liveness probes, so we don't need the
controller internal health server to be running.
The controller internal health server is using the same port
which leads to this error:
```
2024-07-31T15:58:53.582Z error inmemorychannel-dispatcher sharedmain/main.go:334 Error while running server {"commit": "b7bfc92", "knative.dev/pod": "imc-dispatcher-696d94588d-j7fr5", "error": "listen tcp :8080: bind: address already in use"}
knative.dev/pkg/injection/sharedmain.MainWithConfig
knative.dev/pkg@v0.0.0-20240716082220-4355f0c73608/injection/sharedmain/main.go:334
knative.dev/pkg/injection/sharedmain.MainWithContext
knative.dev/pkg@v0.0.0-20240716082220-4355f0c73608/injection/sharedmain/main.go:209
main.main
knative.dev/eventing/cmd/in_memory/channel_dispatcher/main.go:47
runtime.main
runtime/proc.go:271
```
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow
bot
added
the
size/XS
knative-prow
bot
added
the
approved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8125 +/- ##
==========================================
- Coverage 67.88% 67.88% -0.01%
==========================================
Files 368 368
Lines 17554 17555 +1
==========================================
Hits 11917 11917
- Misses 4891 4892 +1
Partials 746 746 ☔ View full report in Codecov by Sentry. |
|
/test unit-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IMC dispatcher is using the same server receiving events for k8s readiness and liveness probes, so we don't need the controller internal health server to be running.
The controller internal health server is using the same port which leads to this error: