Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect #917. #971

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

Harwayne
Copy link
Contributor

Proposed Changes

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 25, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2019
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2019
@evankanderson
Copy link
Member

/assign @vaikas-google

@srinivashegde86
Copy link
Contributor

/retest

@vaikas
Copy link
Contributor

vaikas commented Mar 25, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Harwayne,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 45f9a8d into knative:master Mar 26, 2019
matzew added a commit to matzew/eventing that referenced this pull request Nov 16, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing that referenced this pull request Nov 19, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing that referenced this pull request Nov 19, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
cardil pushed a commit to cardil/knative-eventing that referenced this pull request Nov 19, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing that referenced this pull request Nov 24, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants