Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting Knative Service when requested in the CLI using --dry-run #1060

Closed
salaboy opened this issue Jun 14, 2022 · 10 comments
Closed

Exporting Knative Service when requested in the CLI using --dry-run #1060

salaboy opened this issue Jun 14, 2022 · 10 comments
Assignees
@salaboy
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@salaboy
Copy link
Member

salaboy commented Jun 14, 2022 •
edited
Loading

As discussed in this issue: #817
As discussed in the weekly meeting

The func CLI should:

  • Allow the user to export the Knative Service that is being created programmatically using --dry-run

This will allow users to save the resource and apply it manually if they want to override some configurations.
@salaboy salaboy self-assigned this Jun 14, 2022
@salaboy salaboy mentioned this issue Jun 14, 2022
Closed
@lance lance moved this to Icebox (backlog and controversial items) in Func Roadmap Jun 14, 2022
@lance lance moved this from Icebox (backlog and controversial items) to In Design (typically large tasks with a feature track) in Func Roadmap Jun 14, 2022
@salaboy salaboy changed the title Exporting Knative Service when requested in the CLI Exporting Knative Service when requested in the CLI using --dry-run Jun 14, 2022
@salaboy
Copy link
Member Author

salaboy commented Jul 1, 2022

After trying to create my own --dry-run printers I've realized that there is a "similar" functionality in kn that we can/should use.

The kn cli already provides a sort of dry run with the --target parameter which dumps the output of commands into a file. They also have knServingGitOpsClient which is an alternative implementation of the Knative serving clients that do all the dumping resources to files.

@zroubalik I am not sure if you have looked into the on-cluster build dry runs.. but so far I think that we should reuse the kn cli mechanisms.

I've started to think that my first implementation will follow the same approach of asking for a --target flag which points to a file where the resources are going to be written. This in my opinion is not very "gitops-y", but I do understand some of the reasons why this might have been designed in this way. From what I understand looking at the kn code when --target is provided nothing is applied to the cluster.

Internally this is using &printers.YAMLPrinter{} to print YAMLs with different options.

@lance @lkingland @matejvasek any thoughts?

@salaboy salaboy mentioned this issue Jul 5, 2022
Open
@salaboy
Copy link
Member Author

salaboy commented Jul 5, 2022

Quick update, I've written a comment on the client issue linked above to see if we can expand the kn client capabilities so we can reuse them here in func. I will create a draft PR in the meantime.

@salaboy salaboy mentioned this issue Jul 5, 2022
Closed
@lance lance moved this from In Design to In Progress in Func Roadmap Jul 12, 2022
@salaboy
Copy link
Member Author

salaboy commented Jul 12, 2022

knative/client#1195

@lance lance added this to the 0.99.0 Release milestone Jul 28, 2022
@lance lance modified the milestones: 0.99.0 Release, 1.0.0 Release Sep 14, 2022
@lance lance modified the milestones: 1.8.0 Release, 1.9.0 Release Oct 4, 2022
@lance lance moved this from In Progress to In Design in Func Roadmap Oct 4, 2022
@lance lance moved this to ✏ In Design in Functions WG Roadmap Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2023
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2023
@lance lance modified the milestones: 1.9.0 Release, Release 1.10 Feb 14, 2023
@lance lance moved this from ✏ In Design to ❄ Icebox / Backlog in Functions WG Roadmap Mar 21, 2023
@lance lance removed this from the Release 1.10 milestone May 16, 2023
@lance lance added this to the Release 1.11 milestone May 16, 2023
@lance lance removed the MVP label May 16, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2023
@lkingland lkingland added kind/feature-request and removed kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 23, 2023
@lkingland lkingland removed this from the Release 1.11 milestone Aug 23, 2023
@lkingland lkingland mentioned this issue Oct 15, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2024
@lkingland lkingland removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2024
@matejvasek
Copy link
Contributor

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2024
@github-project-automation github-project-automation bot moved this from ❄ Icebox to ✅ Done in Functions WG Roadmap Oct 20, 2024
gauron99 pushed a commit to gauron99/func that referenced this issue Feb 15, 2025
@serverless-qe
[release-v1.15] Sync Konflux configurations (knative#1060)
70b5453 
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salaboy salaboy

Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
Functions WG Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Initial dry-run using client NewServingClientGitOps salaboy/kn-plugin-func
5 participants
@lance @salaboy @zroubalik @matejvasek @lkingland