Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cryptic error message: registry is required #1504

Closed
aslom opened this issue Jan 18, 2023 · 1 comment · Fixed by #1510
Closed

Cryptic error message: registry is required #1504

aslom opened this issue Jan 18, 2023 · 1 comment · Fixed by #1510
Assignees
@lance

Comments

@aslom
Copy link
Member

aslom commented Jan 18, 2023 

func run
   Building function image
Error: registry is required

func run --build
   Building function image
Error: registry is required

I think it is fixed by option --registry or setting $FUNC_REGISTRY?

Maybe that could be in error message mentioned?
@lance
Copy link
Member

lance commented Jan 19, 2023

/assign

lance added a commit to lance/func that referenced this issue Jan 19, 2023
@lance
fix: improve error message for missing registry name
7cda849 
When a user attempts to build, run or deploy a function and it has not
been previously built, the `--registry` flag or `FUNC_REGISTRY` environment
variable must be set so that the image name can be calculated. The
current error message, `registry required` is not very helpful, and
requires the user to divine what needs to happen next to fix the
problem. This change updates the error message text to indicate that the
user should set the `--registry` flag or `FUNC_REGISTRY` environment
variable.

Fixes: knative#1504

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance mentioned this issue Jan 19, 2023
Merged
knative-prow bot pushed a commit that referenced this issue Jan 20, 2023
@lance
fix: improve error message for missing registry name (#1510)
2b1ab1b 
When a user attempts to build, run or deploy a function and it has not
been previously built, the `--registry` flag or `FUNC_REGISTRY` environment
variable must be set so that the image name can be calculated. The
current error message, `registry required` is not very helpful, and
requires the user to divine what needs to happen next to fix the
problem. This change updates the error message text to indicate that the
user should set the `--registry` flag or `FUNC_REGISTRY` environment
variable.

Fixes: #1504

Signed-off-by: Lance Ball <lball@redhat.com>

Signed-off-by: Lance Ball <lball@redhat.com>
lance added a commit to lance/func that referenced this issue Feb 15, 2023
@lance
fix: improve error message for missing registry name (knative#1510)
6960b27 
When a user attempts to build, run or deploy a function and it has not
been previously built, the `--registry` flag or `FUNC_REGISTRY` environment
variable must be set so that the image name can be calculated. The
current error message, `registry required` is not very helpful, and
requires the user to divine what needs to happen next to fix the
problem. This change updates the error message text to indicate that the
user should set the `--registry` flag or `FUNC_REGISTRY` environment
variable.

Fixes: knative#1504

Signed-off-by: Lance Ball <lball@redhat.com>

Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance lance

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve error message for missing registry name lance/func
2 participants
@lance @aslom